From 4f68a563c635bd8fc7637d66485a341e35ed306a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hannes=20K=C3=B6rber?= Date: Sat, 28 May 2022 22:24:23 +0200 Subject: [PATCH] providers: Use references for field access --- src/provider/github.rs | 12 ++++++------ src/provider/gitlab.rs | 12 ++++++------ src/provider/mod.rs | 6 +++--- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/src/provider/github.rs b/src/provider/github.rs index 8c05c53..42a75cf 100644 --- a/src/provider/github.rs +++ b/src/provider/github.rs @@ -88,20 +88,20 @@ impl Provider for Github { }) } - fn name(&self) -> String { - String::from(PROVIDER_NAME) + fn name(&self) -> &str { + PROVIDER_NAME } - fn filter(&self) -> Filter { - self.filter.clone() + fn filter(&self) -> &Filter { + &self.filter } fn secret_token(&self) -> &auth::AuthToken { &self.secret_token } - fn auth_header_key() -> String { - "token".to_string() + fn auth_header_key() -> &'static str { + "token" } fn get_user_projects( diff --git a/src/provider/gitlab.rs b/src/provider/gitlab.rs index bbbfa99..2dc2132 100644 --- a/src/provider/gitlab.rs +++ b/src/provider/gitlab.rs @@ -105,20 +105,20 @@ impl Provider for Gitlab { }) } - fn name(&self) -> String { - String::from(PROVIDER_NAME) + fn name(&self) -> &str { + PROVIDER_NAME } - fn filter(&self) -> Filter { - self.filter.clone() + fn filter(&self) -> &Filter { + &self.filter } fn secret_token(&self) -> &auth::AuthToken { &self.secret_token } - fn auth_header_key() -> String { - "bearer".to_string() + fn auth_header_key() -> &'static str { + "bearer" } fn get_user_projects( diff --git a/src/provider/mod.rs b/src/provider/mod.rs index 27c1e29..a1c9a9c 100644 --- a/src/provider/mod.rs +++ b/src/provider/mod.rs @@ -122,10 +122,10 @@ pub trait Provider { where Self: Sized; - fn name(&self) -> String; - fn filter(&self) -> Filter; + fn name(&self) -> &str; + fn filter(&self) -> &Filter; fn secret_token(&self) -> &auth::AuthToken; - fn auth_header_key() -> String; + fn auth_header_key() -> &'static str; fn get_user_projects( &self,