Fix duplicated changed_when

playbook.yml

@@ -10,6 +10,12 @@
       tags:
         - always
 
+    - name: read variables
+      include_vars:
+        file: variables.yml
+      tags:
+        - always
+
     - set_fact:
         distro: "{{ ansible_distribution|lower }}"
       tags:
@@ -406,33 +412,13 @@
         shell: . ~/.cargo/env && rustup default stable
         become: true
         become_user: rust_build
+        changed_when: false
 
       - name: update rustup stable toolchain
         shell: . ~/.cargo/env && rustup update stable
         become: true
         become_user: rust_build
-
+        changed_when: false
-      - name: set crate list
-        set_fact:
-          cargo_crate_list:
-            - crate: just
-              binary: just
-              version: 0.10.2
-            - crate: ripgrep
-              binary: rg
-              version: 13.0.0
-            - crate: fd-find
-              binary: fd
-              version: 8.2.1
-            - crate: bat
-              binary: bat
-              version: 0.18.3
-            - crate: exa
-              binary: exa
-              version: 0.10.1
-            - crate: watchexec-cli
-              binary: watchexec
-              version: 1.17.1
 
       - name: build rust crates
         shell: |
@@ -478,10 +464,6 @@
         - rust_binaries
 
     - block:
-      - name: set go version
-        set_fact:
-          go_version: "1.17.1"
-
       - name: stat go target directory
         stat:
           path: /usr/local/go-v{{ go_version }}
@@ -696,6 +678,7 @@
           become: true
           become_user: "{{ user.name }}"
       with_items: "{{ users }}"
+      no_log: True # less spam
       loop_control:
         loop_var: user
       tags:

user.yml

@@ -327,7 +327,6 @@
 
   - name: update vim plugins
     command: sh -c 'PATH=/usr/local/go/bin:$PATH GOROOT=/usr/local/go GOPATH=/home/{{ user.name }}/.go /usr/bin/nvim --headless +PlugUpdate +qall'
-    changed_when: false
     register: vim_plugin_update
     changed_when: vim_plugin_update.stderr != ""
     tags: [update]
@@ -477,10 +476,6 @@
     - firefox
 
 - block:
-  - name: set portfolio performance version
-    set_fact:
-      portfolio_performace_version: "0.55.0"
-
   - name: look of current installation
     stat:
       path: /home/{{ user.name }}/.opt/portfolio-performance-{{ portfolio_performace_version }}
@@ -542,10 +537,6 @@
     - portfolio-performance
 
 - block:
-  - name: set kubectl version
-    set_fact:
-      kubectl_version: v1.22.2
-
   - name: get current stable version
     uri:
       url: https://storage.googleapis.com/kubernetes-release/release/stable.txt
@@ -588,10 +579,6 @@
     - kubectl
 
 - block:
-  - name: set terraform version
-    set_fact:
-      terraform_version: 1.0.2
-
   - name: stat current terraform binary
     stat:
       path: "/home/{{ user.name }}/.opt/terraform-v{{ terraform_version }}"
@@ -635,6 +622,7 @@
   - name: get terraform version info
     command: /home/{{ user.name }}/.optbin/terraform version -json
     register: terraform_version_output
+    check_mode: false
     changed_when: false
 
   - name: parse terraform version output

variables.yml

@@ -0,0 +1,23 @@
+terraform_version: 1.0.2
+kubectl_version: v1.22.3
+go_version: "1.17.1"
+portfolio_performace_version: "0.55.0"
+cargo_crate_list:
+  - crate: just
+    binary: just
+    version: 0.10.2
+  - crate: ripgrep
+    binary: rg
+    version: 13.0.0
+  - crate: fd-find
+    binary: fd
+    version: 8.2.1
+  - crate: bat
+    binary: bat
+    version: 0.18.3
+  - crate: exa
+    binary: exa
+    version: 0.10.1
+  - crate: watchexec-cli
+    binary: watchexec
+    version: 1.17.1