From 43b9dd3b08b180c35a17bb88e71a885c11cd78da Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Hannes=20K=C3=B6rber?= <hannes@hkoerber.de>
Date: Fri, 26 Apr 2024 12:20:43 +0200
Subject: [PATCH] Try to make systemd unit handling idempotent

---
 user.yml | 38 ++++++++++++++++++++++----------------
 1 file changed, 22 insertions(+), 16 deletions(-)

diff --git a/user.yml b/user.yml
index b3e3fb0..a243f72 100644
--- a/user.yml
+++ b/user.yml
@@ -39,23 +39,29 @@
     - "/home/{{ user.name }}/.config/systemd/"
     - "/home/{{ user.name }}/.config/systemd/user/"
 
-- set_fact:
-    undesired_user_services:
-      - gpg-agent.socket
-      - gpg-agent.sock.service
-      - gpg-agent-browser.socket
-      - gpg-agent-ssh.socket
-      - gpg-agent-extra.socket
-      - xdg-user-dirs-update.service
-      - gnome-keyring-daemon.service
+- name: disable undesired services
+  tags:
+    - undesired-services
+  block:
+    - set_fact:
+        undesired_user_services:
+          - gpg-agent.socket
+          - gpg-agent.sock.service
+          - gpg-agent-browser.socket
+          - gpg-agent-ssh.socket
+          - gpg-agent-extra.socket
+          - xdg-user-dirs-update.service
+          - gnome-keyring-daemon.service
 
-# systemd needs a login session, machinectl handles that for us
-- name: stop and mask undesired services
-  command:
-    cmd: machinectl --uid {{ user.name }} shell -- .host /usr/bin/env systemctl --user mask --now "{{ item }}"
-  become: true
-  become_user: root
-  loop: "{{ undesired_user_services }}"
+    # systemd needs a login session, machinectl handles that for us
+    - name: stop and mask undesired services
+      command:
+        cmd: machinectl --quiet --uid {{ user.name }} shell -- .host /usr/bin/env systemctl --user mask --now "{{ item }}"
+      become: true
+      become_user: root
+      register: undesired_service_cmd
+      changed_when: undesired_service_cmd.stderr != ""
+      loop: "{{ undesired_user_services }}"
 
 - name: create directory for getty autologin
   file: